Fix erroneous URL encoding of final output filenames #1446
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1446 +/- ##
==========================================
+ Coverage 65.77% 65.80% +0.02%
==========================================
Files 91 91
Lines 16054 16050 -4
Branches 4059 4055 -4
==========================================
+ Hits 10560 10562 +2
+ Misses 4359 4355 -4
+ Partials 1135 1133 -2
Continue to review full report at Codecov.
|
|
@mr-c I've added the changes you requested. Please let me know if there are any issues with the approach I've taken with my unit test |
There was a problem hiding this comment.
https://github.com/common-workflow-language/cwltool/pull/1446/files shows a couple lines without test coverage; can you investigate?
|
Of course. I can address both of these requests but it will be a little over a week before I have a chance to take a look. |
…ly, it corrects the erroneous URL encoding of output file basenames and nameroots when collecting final outputs.
…map(). The changes in collect_output() are formatting only. Unit test for collect_output() are complete
3 participants
Fixes #1445; command_line_tool.collect_output() now URL decodes output file
basenames, and uses the decoded result to determine thenamerootandnameextfields